-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Can't lint go 1.22 package #19
Comments
Aside that's unrelated to the primary go version at hand, that |
@Crocmagnon I'm unfortunately unable to reproduce, running below: # josh @ M-FTQC4VW0R3 in ~/Desktop/main-test on git:main x [19:25:04]
$ go version
go version go1.22.2 darwin/arm64
# josh @ M-FTQC4VW0R3 in ~/jjti/go-spancheck on git:jjti/fix-warn-start-span o [19:15:06]
$ go install github.com/jjti/go-spancheck/cmd/spancheck@latest
go: downloading github.com/jjti/go-spancheck v0.6.1
# josh @ M-FTQC4VW0R3 in ~/Desktop/main-test on git:main x [19:20:53]
$ cat go.mod
module github.com/jjti/test
go 1.22.2
# josh @ M-FTQC4VW0R3 in ~/Desktop/main-test on git:main x [19:20:55]
$ ls
go.mod main.go
# josh @ M-FTQC4VW0R3 in ~/Desktop/main-test on git:main x [19:20:56]
$ cat main.go
package main
import "fmt"
func main() {
fmt.Println("hello, world")
}
# josh @ M-FTQC4VW0R3 in ~/Desktop/main-test on git:main x [19:20:58]
$ spancheck ./... |
I tried cloning the repo and building it with my local toolchain (go 1.21), I'm getting the same error as reported. Finally, I tried to install go-spancheck with the go1.22 toolchain after cleaning the modcache, but I'm getting the same error as reported. Tested on master, commit 1288474 |
@Crocmagnon I'm sorry to say I could never repro this issue. But I just upgraded the go version to 1.22.1 (in line with testifylint). Please let me know if you see the issue still after upgrading: 926dd06 |
Describe the bug
I'm trying to lint a module requiring go 1.22.
Log:
To Reproduce
go.mod
:main.go
:Expected behavior
The package should be linted properly and, in this case, not report any error.
Also there's an unexpected warning about the new start span signature.
Additional context
I installed
spancheck
withgo1.22.2
:The text was updated successfully, but these errors were encountered: