Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate should not allow inline comments #32

Open
jjmschofield opened this issue Aug 4, 2020 · 1 comment
Open

validate should not allow inline comments #32

jjmschofield opened this issue Aug 4, 2020 · 1 comment

Comments

@jjmschofield
Copy link
Owner

As per:

"Invalid syntax includes inline comments and user or team names that do not exist on GitHub."

https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners

@AndersDJohnson
Copy link

@jjmschofield Hey! Sorry to bother, but do we know if this is still the case as far as GitHub support goes? Recently noticed your github-codeowners tool was not able to parse a line like:

my-file @my-owner # my comment

with Error: # is not a valid codeowner name in rule

But GitHub's new CODEOWNERS validation indicated it was ok... maybe not, didn't get around to testing if it still applied the rules...

Happy to try to contribute a fix if you're open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants