From 11d703a1fcd2b5c64f02cff8761a667125b6c698 Mon Sep 17 00:00:00 2001 From: Ilya Grigoriev <ilyagr@users.noreply.github.com> Date: Wed, 15 Jan 2025 16:41:44 -0800 Subject: [PATCH] dymanic completions: test a hack that checks availability of generated completions https://github.com/fish-shell/fish-shell/pull/11046 relies on this behavior. --- cli/tests/test_completion.rs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/cli/tests/test_completion.rs b/cli/tests/test_completion.rs index a940f084c1..16f8f9ce24 100644 --- a/cli/tests/test_completion.rs +++ b/cli/tests/test_completion.rs @@ -210,8 +210,12 @@ fn test_completions_are_generated() { // cannot use assert_snapshot!, output contains path to binary that depends // on environment assert!(stdout.starts_with("complete --keep-order --exclusive --command jj --arguments")); - let stdout = test_env.jj_cmd_success(test_env.env_root(), &["--"]); - assert!(stdout.starts_with("complete --keep-order --exclusive --command jj --arguments")); + let stdout_dashdash = test_env.jj_cmd_success(test_env.env_root(), &["--"]); + assert_eq!(stdout, stdout_dashdash); + // Used in https://github.com/fish-shell/fish-shell/pull/11046 to check + // whether `jj` is new enough to support dynamic completions + let stdout_unknowncommand = test_env.jj_cmd_success(test_env.env_root(), &["random-command"]); + assert_eq!(stdout, stdout_unknowncommand); } #[test]