sidecar: disable WithTemporaryBatchSize option

jitsucom · Dec 4, 2024 · 4841ade · 4841ade
1 parent 8281314
commit 4841ade
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/bulkerlib/implementations/sql/snowflake.go b/bulkerlib/implementations/sql/snowflake.go
@@ -298,8 +298,7 @@ func (s *Snowflake) GetTableSchema(ctx context.Context, namespace string, tableN
 
 	primaryKeyName, pkFields, err := s.getPrimaryKey(ctx, namespace, tableName)
 	if err != nil {
-		s.Errorf("failed to get primary key for table %s: %v", tableName, err)
-		//return nil, err
+		return nil, err
 	}
 
 	table.PKFields = pkFields

diff --git a/sync-sidecar/read.go b/sync-sidecar/read.go
@@ -6,7 +6,6 @@ import (
 	"errors"
 	"fmt"
 	bulker "github.com/jitsucom/bulker/bulkerlib"
-	"github.com/jitsucom/bulker/bulkerlib/implementations/sql"
 	"github.com/jitsucom/bulker/eventslog"
 	"github.com/jitsucom/bulker/jitsubase/jsonorder"
 	"github.com/jitsucom/bulker/jitsubase/pg"
@@ -444,9 +443,9 @@ func (s *ReadSideCar) openStream(streamName string) (*ActiveStream, error) {
 	} else if len(str.DefaultCursorField) > 0 {
 		streamOptions = append(streamOptions, bulker.WithDiscriminatorField(str.DefaultCursorField))
 	}
-	if str.SyncMode != "incremental" || forceTemporaryBatchesSources.Contains(s.packageName) {
-		streamOptions = append(streamOptions, sql.WithTemporaryBatchSize(100000))
-	}
+	//if str.SyncMode != "incremental" || forceTemporaryBatchesSources.Contains(s.packageName) {
+	//	streamOptions = append(streamOptions, sql.WithTemporaryBatchSize(100000))
+	//}
 	if namespace != "" {
 		streamOptions = append(streamOptions, bulker.WithNamespace(namespace))
 	}