Skip to content

Commit

Permalink
bulker: remove redundant columns count limit warning
Browse files Browse the repository at this point in the history
  • Loading branch information
absorbb committed Nov 29, 2024
1 parent 611c644 commit 3d71673
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions bulkerlib/implementations/sql/table_helper.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ type TableHelper struct {
coordinationService coordination.Service
tablesCache map[string]*Table

maxColumns int

maxIdentifierLength int
identifierQuoteStr string
useQuoting bool
Expand All @@ -51,8 +49,6 @@ func NewTableHelper(maxIdentifierLength int, identifierQuoteChar rune) TableHelp
coordinationService: coordination.DummyCoordinationService{},
tablesCache: map[string]*Table{},

maxColumns: 1000,

maxIdentifierLength: maxIdentifierLength,
identifierQuoteStr: string(identifierQuoteChar),
useQuoting: identifierQuoteChar != 0,
Expand Down Expand Up @@ -184,15 +180,6 @@ func (th *TableHelper) patchTableIfNeeded(ctx context.Context, sqlAdapter SQLAda
return currentSchema, nil
}

//check if max columns error
if th.maxColumns > 0 {
columnsCount := currentSchema.ColumnsCount() + diff.ColumnsCount()
if columnsCount > th.maxColumns {
//return nil, fmt.Errorf("Count of columns %d should be less or equal 'server.max_columns' (or destination.data_layout.max_columns) setting %d", columnsCount, th.maxColumns)
logging.Warnf("[%s] Count of columns %d should be less or equal 'server.max_columns' (or destination.data_layout.max_columns) setting %d", destinationID, columnsCount, th.maxColumns)
}
}

//** Diff exists **
//patch table schema
return th.patchTableWithLock(ctx, sqlAdapter, destinationID, currentSchema, diff)
Expand Down

0 comments on commit 3d71673

Please sign in to comment.