Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(screen-sharing) fix depredcated ss hook #369

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

saghul
Copy link
Member

@saghul saghul commented Jan 16, 2024

We may fail to access the iframe's contentWindow, but we can ignore that since the new hook doesn't require it.

Fixes: #368
Fixes: #325

We may fail to access the iframe's contentWindow, but we can ignore that
since the new hook doesn't require it.

Fixes: #368
Fixes: #325
Copy link
Member

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@saghul saghul merged commit 6f0f561 into master Jan 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants