JVB HTTP servers should be configurable #1013
Open
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those 4 new envs would enable the http server interface to be configured. This would be especially helpful in a kubernetes environment, where I use `hostNetwork: true` but I don't want the private http server to be exposed to the public. Default values would stay the same. Cheers.
saghul
reviewed
May 18, 2021
jvb/rootfs/defaults/jvb.conf
Outdated
| @@ -45,11 +45,12 @@ videobridge { | |||
| } | |||
| http-servers { | |||
| private { | |||
| host = 0.0.0.0 | |||
| host = "{{ .Env.JVB_HTTP_SERVER_PRIVATE_ADDRESS | default "0.0.0.0" }}" | |||
There was a problem hiding this comment.
I don't think this needs quotation marks.
There was a problem hiding this comment.
I copied the style from the other config options:
https://github.com/jitsi/docker-jitsi-meet/blob/master/jvb/rootfs/defaults/jvb.conf#L59
But I'll remove the quotation marks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those 4 new envs would enable the http server interface to be configured.
This would be especially helpful in a kubernetes environment, where I use
hostNetwork: truebut I don't want the private http server to be exposed to the public.Default values would stay the same.
Cheers.