Enable unit test

enable unit test by uncommenting main in .prow.sh. Add test module in Makefile. Due to the issue related to guid package microsoft/go-winio#169 which causes errors when running unit tests on Linux, the current solution is to add some filter for the test path. Will update it after the issue is resolved.
jingxu97 · Feb 3, 2020 · 1cf72c3 · 1cf72c3
1 parent 06d2e21
commit 1cf72c3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.prow.sh b/.prow.sh
@@ -9,4 +9,4 @@
 
 # TODO: Once we add windows build rules and a Makefile, we can enable
 # some basic unit testing
-# main
+main
diff --git a/Makefile b/Makefile
@@ -74,6 +74,14 @@ lint: $(GOLANGCI_LINT)
 	$(GO_ENV_VARS) $(GOLANGCI_LINT) run
 	git --no-pager diff --exit-code
 
+.PHONY: test-go
+test: test-go
+test-go:
+	@ echo; echo "### $@:"
+	# TODO: After issue https://github.com/microsoft/go-winio/pull/169 is resolved, remove the filter on the test path.
+	go test `find ./internal/server/ -type d -not -name server`;\
+	go test `go list ./client/apiversion/...`
+
 # see https://github.com/golangci/golangci-lint#binary-release
 $(GOLANGCI_LINT):
 	curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b "$$(dirname '$(GOLANGCI_LINT)')" '$(GOLANGCI_LINT_VERSION)'
-Original file line number
+Diff line change
@@ Expand Up / @@ -9,4 +9,4 @@ @@
     # TODO: Once we add windows build rules and a Makefile, we can enable
     # some basic unit testing
-    # main
+    main