Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce deterministic results order on 'needs' in topology graph #4084

Closed
alaeddine-13 opened this issue Dec 22, 2021 · 2 comments · Fixed by #5366
Closed

Enforce deterministic results order on 'needs' in topology graph #4084

alaeddine-13 opened this issue Dec 22, 2021 · 2 comments · Fixed by #5366
Assignees
@JoanFM
Labels
epic/3.0 All tasks related to development on 3.0 priority/backlog Agreement that this is a nice-to-have, but no one's can work on it now. Community support welcome Stale type/maintenance This issue is not a bug or a feature_request.

Comments

@alaeddine-13
Copy link
Contributor

When making requests to pods running in parallel, the topology graph should await all tasks together to have a deterministic ordering (similar to asyncio.gather in the head runtime)
@CatStark CatStark added priority/important-longterm Important over the long term, but not at the moment type/maintenance This issue is not a bug or a feature_request. epic/3.0 All tasks related to development on 3.0 labels Dec 22, 2021
@CatStark CatStark added priority/backlog Agreement that this is a nice-to-have, but no one's can work on it now. Community support welcome and removed priority/important-longterm Important over the long term, but not at the moment labels Feb 28, 2022
@jina-bot
Copy link
Member

@jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days

@jina-bot jina-bot added the Stale label May 30, 2022
@JoanFM JoanFM closed this as completed Jun 12, 2022
@JoanFM JoanFM mentioned this issue Oct 28, 2022
Closed
@JoanFM JoanFM reopened this Oct 28, 2022
@alaeddine-13 alaeddine-13 mentioned this issue Oct 28, 2022
Closed
@JoanFM JoanFM self-assigned this Nov 8, 2022
@JoanFM JoanFM linked a pull request Nov 8, 2022 that will close this issue
feat: pass docs_map to Executor #5366
Merged
@JoanFM
Copy link
Member

JoanFM commented Nov 9, 2022

Closed as it will be handled by #5330

@JoanFM JoanFM closed this as completed Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoanFM JoanFM

Labels
epic/3.0 All tasks related to development on 3.0 priority/backlog Agreement that this is a nice-to-have, but no one's can work on it now. Community support welcome Stale type/maintenance This issue is not a bug or a feature_request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: pass docs_map to Executor jina-ai/serve
4 participants
@CatStark @alaeddine-13 @JoanFM @jina-bot