Empty cookie names throw a ValidationException

[flyingfischer]

I do see org.jsoup.helper.ValidationException: The 'name' parameter must not be empty since 1.18.2.

I also tried a fresh build from master which includes ed23a9a with no success.

I cannot nail it down to a certain condition, but it happens on response.parse() after using Jsoup.connect.

[jhy]

Can you start by providing the stacktrace?

And can you log your input parameters and provide those for the case where you see the exception?

[flyingfischer]

The stacktrace is:

org.jsoup.helper.ValidationException: The 'name' parameter must not be empty.
at org.jsoup.helper.HttpConnection$Base.cookie(HttpConnection.java:569)
at org.jsoup.helper.HttpConnection$Response.cookie(HttpConnection.java:797)
at org.jsoup.helper.CookieUtil.storeCookies(CookieUtil.java:109)
at org.jsoup.helper.HttpConnection$Response.(HttpConnection.java:1136)
at org.jsoup.helper.HttpConnection$Response.execute(HttpConnection.java:869)
at org.jsoup.helper.HttpConnection$Response.execute(HttpConnection.java:830)
at org.jsoup.helper.HttpConnection.execute(HttpConnection.java:351)
at util.WebsiteMonitor.jsoupResponse(WebsiteMonitor.java:424)
at util.WebsiteMonitor.getJsoupDoc(WebsiteMonitor.java:110)
at util.WebsiteMonitor.getDoc(WebsiteMonitor.java:88)
at ch.sc.cronjobs.News.execute(News.java:75)

[JH- snipped 130 lines]

[flyingfischer]

Calling with something like

Jsoup.connect(link).sslSocketFactory(sslContext.getSocketFactory()) .header("Accept", Constants.ACCEPT.getValue()) .header("Accept-Language", Constants.ACCEPT_LANGUAGE.getValue()) .header("DNT", "1").userAgent(Constants.USER_AGENT.getValue()).timeout(20000).execute();

Target in this case is https://shs.cairn.info/journal-a-contrario?lang=fr

The error is being thrown at response.parse()

[jhy]

Thanks -- fixed. I wasn't able to directly repro on that URL as it was not sending un-named cookies when I tried, but that would be the cause. I added the missing empty name check that was used in previous versions of jsoup.

[flyingfischer]

Perfect! The most recent snapshot fixes the issue here. Thanks for your great work!

[jhy]

Great, thanks for confirming