Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Landscape.vue #7590

Closed
pascalgrimaud opened this issue Sep 26, 2023 · 12 comments · Fixed by #7803
Closed

Refactoring: Landscape.vue #7590

pascalgrimaud opened this issue Sep 26, 2023 · 12 comments · Fixed by #7803
Assignees
Labels
area: refactoring $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ generator: internal $100 https://www.jhipster.tech/bug-bounties/

Comments

@pascalgrimaud
Copy link
Member

The CSS part should be moved into style/ folder

@pascalgrimaud pascalgrimaud added generator: internal area: refactoring $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $100 https://www.jhipster.tech/bug-bounties/ labels Sep 26, 2023
@murdos
Copy link
Contributor

murdos commented Sep 27, 2023

I'm going to try to fix this one

@qmonmert
Copy link
Contributor

qmonmert commented Oct 5, 2023

@murdos I can do this ticket if you don't have time 🙂

@murdos
Copy link
Contributor

murdos commented Oct 5, 2023

@murdos I can do this ticket if you don't have time 🙂

Thanks, but I would like to do it since it's not my area of expertise and I would like to try and learn.
I'll tell you if I give up so you can take over 🙂

@qmonmert
Copy link
Contributor

qmonmert commented Oct 5, 2023

@murdos ok 🤝

@pascalgrimaud
Copy link
Member Author

@qmonmert : I didn't create other tickets but the goal is to extract the css to tikui, so it's easy to find other part to work on this

@qmonmert
Copy link
Contributor

qmonmert commented Oct 5, 2023

@pascalgrimaud ok 👍

@qmonmert
Copy link
Contributor

@murdos always motivated to do this? it's the last file to refactor and after that we we'll be able to refactor some global CSS

@murdos
Copy link
Contributor

murdos commented Oct 19, 2023

@qmonmert : feel free to pick it

@murdos murdos assigned qmonmert and unassigned murdos Oct 19, 2023
@qmonmert
Copy link
Contributor

@murdos sure?

@murdos
Copy link
Contributor

murdos commented Oct 19, 2023

@murdos sure?

Sure 😉. I'm busy with the yaml spring configuration right now and real life 😀

@qmonmert
Copy link
Contributor

@pascalgrimaud
Copy link
Member Author

@qmonmert : approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: refactoring $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ generator: internal $100 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants