Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkipClient generating webapp files #23943

Closed
minplaal opened this issue Oct 22, 2023 · 3 comments · Fixed by #24037
Closed

SkipClient generating webapp files #23943

minplaal opened this issue Oct 22, 2023 · 3 comments · Fixed by #24037

Comments

@minplaal
Copy link
Contributor

Overview of the issue

When generating with JHipster 8.0.0-rc1 an application with SkipClient setting enabled, it generates webapp files and should not.

Motivation for or Use Case

Generating server only projects was supported in previous JHipster versions and is expected to be supported with new versions.

Reproduce the error
JHipster configuration, a .yo-rc.json file generated in the root folder
.yo-rc.json file
{
  "generator-jhipster": {
    "applicationType": "monolith",
    "authenticationType": "jwt",
    "baseName": "test",
    "buildTool": "maven",
    "cacheProvider": "ehcache",
    "clientFramework": "angular",
    "clientTestFrameworks": [],
    "clientTheme": "none",
    "creationTimestamp": 1697980623138,
    "databaseType": "sql",
    "devDatabaseType": "h2Disk",
    "devServerPort": 4200,
    "enableGradleEnterprise": null,
    "enableHibernateCache": true,
    "enableSwaggerCodegen": false,
    "enableTranslation": true,
    "entities": [
      "MyTest"
    ],
    "gradleEnterpriseHost": null,
    "jhipsterVersion": "8.0.0-rc.1",
    "languages": [
      "en",
      "fr"
    ],
    "lastLiquibaseTimestamp": 1697980825000,
    "messageBroker": false,
    "microfrontend": null,
    "microfrontends": [],
    "nativeLanguage": "en",
    "packageName": "com.mycompany.myapp",
    "prodDatabaseType": "mssql",
    "reactive": false,
    "searchEngine": false,
    "serverPort": null,
    "serverSideOptions": [],
    "serviceDiscoveryType": false,
    "skipClient": true,
    "testFrameworks": [],
    "websocket": false,
    "withAdminUi": true
  }
}
Environment and Tools

openjdk version "17.0.8.1" 2023-08-24
OpenJDK Runtime Environment (build 17.0.8.1+1-Ubuntu-0ubuntu122.04)
OpenJDK 64-Bit Server VM (build 17.0.8.1+1-Ubuntu-0ubuntu122.04, mixed mode, sharing)

git version 2.34.1

node: v18.18.1
npm: 9.8.1

Docker version 24.0.6, build ed223bc

JDL for the Entity configuration(s) entityName.json files generated in the .jhipster directory
JDL entity definitions
entity MyTest {
  testField String
}
dto MyTest with mapstruct
paginate MyTest with pagination
service MyTest with serviceImpl
search MyTest with no
filter MyTest

Suggest a Fix

Ensure "SkipClient" condition is checked within Language generator, both for loadNativeLanguage and for postWritingEntities

JHipster Version(s)

8.0.0-rc.1

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

JHipster has completed the sample check
.yo-rc.json: valid
Entities JDL: valid
Application: successfully generated
Frontend check: success
Backend check: failure
E2E check: success

@mshima
Copy link
Member

mshima commented Oct 26, 2023

@minplaal can contribute with a PR?

@minplaal
Copy link
Contributor Author

I'll give it a try at least!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants