Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check host for Open in Editor #776

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Don't check host for Open in Editor #776

merged 1 commit into from
Jul 21, 2023

Conversation

jhen0409
Copy link
Owner

@jhen0409 jhen0409 commented Jul 21, 2023 •
edited
Loading

The file link of RN packager like Expo 48 is using IP as host, it doesn't work if set the host as localhost in __RN_PACKAGER_PREFIX__. Remove the host check is probably works fine on most use cases.

@jhen0409 jhen0409 merged commit 16a31be into master Jul 21, 2023
@jhen0409 jhen0409 deleted the fix-host-open-in-editor branch July 21, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jhen0409