Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needing to restart program #44

Closed
RHThree opened this issue Dec 22, 2019 · 4 comments · Fixed by #50
Closed

Needing to restart program #44

RHThree opened this issue Dec 22, 2019 · 4 comments · Fixed by #50
Labels
bug Something isn't working

Comments

@RHThree
Copy link

RHThree commented Dec 22, 2019

My friends and I are trying to use phantom so we can play on a server, but he gets disconnected after a while and has to reenter the command. Any solution or am I missing something? Or is it just a bug?

@cd-champion-dev
Copy link

I've been having this issue while using phantom. It seems to happen more often when both my SO and myself are connected to the same phantom server. It happens at random intervals.

@cd-champion-dev
Copy link

Attached log file from crash

2019-12-31_21-59-15.txt

@jhead
Copy link
Owner

jhead commented Dec 31, 2019

Thanks for the logs @d5c4b3! Definitely looks like a bug. I’ll see what I can find.

@jhead jhead added the bug Something isn't working label Dec 31, 2019
@cd-champion-dev
Copy link

I think it's just concurrent read/write of the idleMap. I forked and added a mutex. It's a very naive lock and might cause issues if idleMap gets big. It might be possible to use sync.RWLock instead. We might also try sync.Map.

I might also be missing an obvious fix. I'm very new to Go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants