-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari's input[disabled] text is too faded #2355
Comments
Hey, What is your thought? Thanks, |
Multiple users reported they were confused, thinking the I agree in part with the sentiment to respect browser defaults. But Bulma is already choosing to override the default I believe this can be considered more of a bug than a stylistic choice. |
Make sense. Especially when the Bulma has taken care of the code to override the browser(s) default style. You should raise the PR with fix as you suggested. |
Is someone working on this? I tried out the fix above and it does fix the issue for me. |
Fixes jgthms#2355 Safari is rendering `disabled` input fields with faded text. Instead of the Bulma default `#7a7a7a` (48% luminosity), the input text renders at `#cecece` (81% luminosity). Multiple users reported confusion, thinking the `<input disabled> value=` was instead `placeholder=` text, because it was so faded. Bulma is [already choosing to override the default `<input disabled>` text `color`](https://github.com/jgthms/bulma/blob/ff8c4c18accf2c0094aa77945b1d2180ac927159/sass/elements/form.sass#L67). That setting simply isn't taking effect in Safari & iOS Safari. This PR fixes it.
PR opened: #2517 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is about Bulma.
Overview of the problem
This is about the Bulma CSS framework.
I'm using Bulma version 0.7.2.
My browser is: Desktop Safari 11.1.2, iOS Safari 10.3.3.
I am sure this issue is not a duplicate.
Description
Safari is rendering
disabled
input fields with faded text.Instead of the Bulma default
#7a7a7a
(48% luminosity), the input text renders at#cecece
(81% luminosity).Steps to Reproduce
Expected behavior
Text color would match across browsers.
Actual behavior
Here's a StackOverflow documenting this issue (not Bulma specific): https://stackoverflow.com/questions/262158/disabled-input-text-color
It looks like one solution is patching
sass/elements/form.sass
:Happy to submit a PR if welcome.
The text was updated successfully, but these errors were encountered: