-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Q: Is it planned to merge this into pip? (A: not for the time being) #43
Comments
What you describe is pip-review was not originally forked from pip, so merging the functionality into pip takes more than just a pull request. Currently, I'm not planning to spend any effort on that. However, I'll open a poll; if this turns out to be a popular request, I may change my mind. (Voters: please attach an emoticon to the opening post.) If you do not want to depend on my whims, you have two options. The first option is to submit a feature request to the pip maintainers and hope that they feel like merging pip-review into pip. The second option is to do the necessary work by yourself and submit a pull request to pip. Make sure to read their contribution guidelines in that case. If you end up submitting a feature or pull request to the pip repository, please put a reference here so I can follow the progress. Thanks in advance. |
I'm somewhat familiar with the situation. because Now, it would actually be possible to implement a dependency solver into
So no, I wouldn't bet on integrating this into |
Thanks for sharing your knowledge on this, @xoviat. I am a bit confused. What does dependency tracking have to do with integrating Answering your questions: (1) Right now, I am somewhat inclined to say "no", but please continue discussing your ideas. Once I better understand the relation between merging into
Note that the last point is more or less neutral. If we do decide to add dependency tracking, we could take advantage of the existing implementation in (2) I may find some time if I am convinced that something needs to be done. You already answered (3) so I won't go into that. ;-) |
I glanced at that implementation and it looks like it downloads packages to discover the requirements. That is really a less than ideal implementation because you may need to backtrack. enthought/sat-solver is a better implementation, but it's currently unworkable because as I said, you need to download the package to discover requirements. |
In case you're wondering the PEP that appears to be blocking everything is PEP 426. Apparently no progress can be made until it's completed, but the current status is "deferred." Possibly it has become bogged down in bureaucracy. |
So what about the |
That has nothing to do with solving dependencies, and it's also being removed in pypa/pip#3939. |
By the way, when I say dependency solver, I mean an algorithm that can address this:
Essentially you need to consider all installed packages along with the packages to be installed and then find a set of distributions that complies with all package requirements; not a trivial thing. In addition, you need to uninstall packages that have their dependencies uninstalled. |
Thank you for the explanation! Closing then. |
This issue is closed, but I originally couldn't find the discussion that I was remembering involving @nlhkabu. For historical purposes, it is in pypi/warehouse#789. |
Hey, I like the idea but don't like to install another package. Instead I would like to see this functionality in native pip. Do you plan to make a pull request?
It would be cool if
pip list
output would look like:The text was updated successfully, but these errors were encountered: