Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the releases should have v prefix #16

Closed
SVilgelm opened this issue Feb 26, 2021 · 1 comment · Fixed by golangci/golangci-lint#1786
Closed

the releases should have v prefix #16

SVilgelm opened this issue Feb 26, 2021 · 1 comment · Fixed by golangci/golangci-lint#1786

Comments

@SVilgelm
Copy link

SVilgelm commented Feb 26, 2021 •
edited
Loading

Hi,
Could you please re-tag (at least latest) releases by adding v prefix to each release?
Seems go get does not recognize the tags without v as versions.

golangci-lint uses github.com/jgautheron/goconst v0.0.0-20201117150253-ccae5bf973f3 in go.mod file, and I tried to update it to use the latest version and expected to see github.com/jgautheron/goconst v1.4.0, but no changes.
Then I found this issue: golang/go#30146
Seems the v is a convention
@jgautheron
Copy link
Owner

I just tagged the last version v1.4.0.

@SVilgelm SVilgelm mentioned this issue Feb 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using a version instead of commit id for goconst golangci/golangci-lint
2 participants
@SVilgelm @jgautheron