GH-548 add data source for remote repos #682

alexhung · 2023-03-03T22:51:42Z

For V7 branch.

Also refactor code in provider and extract data source map and resource map to own files.

Refactor provider to be cleaner Bump docker image version to latest for Artifactory

Fix capitalization on a few package types

Turhsus

Some Qs, some change requests, some indentation errors D:

docs/data-sources/remote_alpine_repository.md

docs/data-sources/remote_bower_repository.md

pkg/artifactory/resource/repository/remote/resource_artifactory_remote_cargo_repository.go

pkg/artifactory/resource/repository/remote/resource_artifactory_remote_helm_repository.go

pkg/artifactory/resource/repository/remote/resource_artifactory_remote_terraform_repository.go

pkg/artifactory/datasource/repository/remote/datasource_artifactory_remote_repository_test.go

…rce-for-remote-repos

…rce-for-remote-repos' into GH-548-add-data-source-for-remote-repos

Turhsus

LGTM

docs/data-sources/remote_docker_repository.md

…e-repos' into GH-548-add-data-source-for-remote-repos

docs/data-sources/remote_helm_repository.md

danielmkn

Some minor formatting

docs/data-sources/remote_nuget_repository.md

docs/data-sources/remote_pypi_repository.md

pkg/artifactory/resource/repository/remote/resource_artifactory_remote_docker_repository.go

pkg/artifactory/provider/provider.go

…docs

Turhsus

LGTM

danielmkn · 2023-03-07T22:44:19Z

docs/resources/artifact_property_webhook.md

 * `criteria` - (Required) Specifies where the webhook will be applied on which repositories.
  * `any_local` - (Required) Trigger on any local repo.
  * `any_remote` - (Required) Trigger on any remote repo.
  * `repo_keys` - (Required) Trigger on this list of repo keys.
-  * `include_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: "org/apache/**".
-  * `exclude_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: "org/apache/**".
+  * `include_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: `org/apache/**`.


/n is rendered as is in the Terraform documentation.

danielmkn · 2023-03-07T22:44:46Z

docs/resources/artifact_webhook.md

 * `criteria` - (Required) Specifies where the webhook will be applied on which repositories.
  * `any_local` - (Required) Trigger on any local repo.
  * `any_remote` - (Required) Trigger on any remote repo.
  * `repo_keys` - (Required) Trigger on this list of repo keys.
-  * `include_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: "org/apache/**".
-  * `exclude_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: "org/apache/**".
+  * `include_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: `org/apache/**`.


Same /n issue.

danielmkn · 2023-03-07T22:44:55Z

docs/resources/artifactory_release_bundle_webhook.md

 * `criteria` - (Required) Specifies where the webhook will be applied on which repositories.
  * `any_release_bundle` - (Required) Trigger on any release bundle
  * `registered_release_bundle_names` - (Required) Trigger on this list of release bundle names
-  * `include_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: "org/apache/**"
-  * `exclude_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: "org/apache/**"
+  * `include_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: `org/apache/**`


danielmkn · 2023-03-07T22:45:03Z

docs/resources/build_webhook.md

 * `criteria` - (Required) Specifies where the webhook will be applied on which repositories.
  * `any_build` - (Required) Trigger on any build.
  * `selected_builds` - (Required) Trigger on this list of build names.
-  * `include_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: "org/apache/**".
-  * `exclude_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: "org/apache/**".
+  * `include_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: `org/apache/**`.


danielmkn · 2023-03-07T22:45:12Z

docs/resources/distribution_webhook.md

 * `criteria` - (Required) Specifies where the webhook will be applied on which repositories.
  * `any_release_bundle` - (Required) Trigger on any release bundle.
  * `registered_release_bundle_names` - (Required) Trigger on this list of release bundle names.
-  * `include_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: "org/apache/**".
-  * `exclude_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: "org/apache/**".
+  * `include_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: `org/apache/**`.


danielmkn · 2023-03-07T22:45:18Z

docs/resources/docker_webhook.md

 * `criteria` - (Required) Specifies where the webhook will be applied on which repositories.
  * `any_local` - (Required) Trigger on any local repo.
  * `any_remote` - (Required) Trigger on any remote repo.
  * `repo_keys` - (Required) Trigger on this list of repo keys.
-  * `include_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: "org/apache/**".
-  * `exclude_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: "org/apache/**".
+  * `include_patterns` - (Optional) Simple comma separated wildcard patterns for repository artifact paths (with no leading slash).\n Ant-style path expressions are supported (*, *\*, ?).\nFor example: `org/apache/**`.


alexhung and others added 4 commits March 2, 2023 16:45

Add data source for remote repositories

59a0aea

Refactor provider to be cleaner Bump docker image version to latest for Artifactory

Add remote repo data source docs

eba4ef6

Fix capitalization on a few package types

Update CHANGELOG

cf7715b

JFrog Pipelines - Add Artifactory version to CHANGELOG.md

1584e7b

alexhung requested review from danielmkn, Turhsus, MahithaB, mritunjaykumar and shrajfr12 March 4, 2023 00:37

alexhung marked this pull request as ready for review March 4, 2023 00:37

Turhsus suggested changes Mar 6, 2023

View reviewed changes

alexhung added 8 commits March 6, 2023 15:32

Fix typo in remote data source documentations

c5ffd41

Fix inconsistent indentations in test hcls

f6179f5

Add additional check for test

d47bc81

Merge remote-tracking branch 'origin/master' into GH-548-add-data-sou…

2c5ea2a

…rce-for-remote-repos

Add missing remote repo data source attributes to doc

e0bdccf

Merge remote-tracking branch 'refs/remotes/origin/GH-548-add-data-sou…

b49321b

…rce-for-remote-repos' into GH-548-add-data-source-for-remote-repos

Remove prefix from HCL examples in doc

33f6588

Remove redundant attribute setting

b2eaef9

alexhung requested a review from Turhsus March 7, 2023 00:23

alexhung and others added 2 commits March 7, 2023 09:09

Remove omitempty from virtual alpine repo field

ed46dd6

JFrog Pipelines - Add Artifactory version to CHANGELOG.md

4609df5

Turhsus previously approved these changes Mar 7, 2023

View reviewed changes

danielmkn reviewed Mar 7, 2023

View reviewed changes

docs/data-sources/remote_docker_repository.md Outdated Show resolved Hide resolved

alexhung added 2 commits March 7, 2023 11:41

Fix markdown formatting for docs

43dab5e

Merge remote-tracking branch 'origin/GH-548-add-data-source-for-remot…

2e5df07

…e-repos' into GH-548-add-data-source-for-remote-repos

alexhung dismissed Turhsus’s stale review via 2e5df07 March 7, 2023 19:42

alexhung requested review from danielmkn and Turhsus March 7, 2023 19:42

danielmkn reviewed Mar 7, 2023

View reviewed changes

docs/data-sources/remote_helm_repository.md Outdated Show resolved Hide resolved

alexhung requested a review from danielmkn March 7, 2023 20:00

Bump acceptance test timeout to 30m

3c89c9f

danielmkn requested changes Mar 7, 2023

View reviewed changes

alexhung added 4 commits March 7, 2023 12:52

Simplify provider rt url validation

ef3580e

Double the testing processes

ef6383c

Remove omit empty from DockerRemoteRepo struct bool field

91e4b56

Replace single or double quotes with backticks for default values in …

122fa3a

…docs

alexhung requested a review from danielmkn March 7, 2023 21:55

Turhsus previously approved these changes Mar 7, 2023

View reviewed changes

danielmkn reviewed Mar 7, 2023

View reviewed changes

Remove \n from docs

56e496e

alexhung dismissed Turhsus’s stale review via 56e496e March 7, 2023 22:49

danielmkn approved these changes Mar 7, 2023

View reviewed changes

alexhung merged commit d50562c into master Mar 7, 2023

alexhung deleted the GH-548-add-data-source-for-remote-repos branch March 7, 2023 23:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-548 add data source for remote repos #682

GH-548 add data source for remote repos #682

alexhung commented Mar 3, 2023

Turhsus left a comment

Turhsus left a comment

danielmkn left a comment

Turhsus left a comment

danielmkn Mar 7, 2023

danielmkn Mar 7, 2023

danielmkn Mar 7, 2023

danielmkn Mar 7, 2023

danielmkn Mar 7, 2023

danielmkn Mar 7, 2023

GH-548 add data source for remote repos #682

GH-548 add data source for remote repos #682

Conversation

alexhung commented Mar 3, 2023

Turhsus left a comment

Choose a reason for hiding this comment

Turhsus left a comment

Choose a reason for hiding this comment

danielmkn left a comment

Choose a reason for hiding this comment

Turhsus left a comment

Choose a reason for hiding this comment

danielmkn Mar 7, 2023

Choose a reason for hiding this comment

danielmkn Mar 7, 2023

Choose a reason for hiding this comment

danielmkn Mar 7, 2023

Choose a reason for hiding this comment

danielmkn Mar 7, 2023

Choose a reason for hiding this comment

danielmkn Mar 7, 2023

Choose a reason for hiding this comment

danielmkn Mar 7, 2023

Choose a reason for hiding this comment