Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-657 update project key validation #662

Merged
merged 4 commits into from
Feb 24, 2023
Merged

GH-657 update project key validation #662

merged 4 commits into from
Feb 24, 2023

Conversation

alexhung
Copy link
Member

@alexhung alexhung commented Feb 23, 2023 •
edited
Loading

Fixes #657

Closes #660

@alexhung alexhung marked this pull request as ready for review February 24, 2023 00:12
@alexhung alexhung requested a review from danielmkn as a code owner February 24, 2023 00:12
Turhsus
Turhsus previously approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@Turhsus Turhsus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexhung alexhung requested a review from Turhsus February 24, 2023 17:21
Turhsus
Turhsus approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@Turhsus Turhsus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexhung alexhung merged commit 1e8bb2c into master Feb 24, 2023
@alexhung alexhung deleted the GH-657-update-project-key-validation branch February 24, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turhsus Turhsus Turhsus approved these changes

@shrajfr12 shrajfr12 shrajfr12 approved these changes

@danielmkn danielmkn Awaiting requested review from danielmkn

@MahithaB MahithaB Awaiting requested review from MahithaB

@mritunjaykumar mritunjaykumar Awaiting requested review from mritunjaykumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project Key
3 participants
@alexhung @Turhsus @shrajfr12