Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTRENG-4591 import tests local repo, fix import issues #652

Merged
merged 9 commits into from
Feb 16, 2023
Merged

PTRENG-4591 import tests local repo, fix import issues #652

merged 9 commits into from
Feb 16, 2023

Conversation

danielmkn
Copy link
Collaborator

  • Fixed import issue for artifactory_remote_docker_repository and artifactory_remote_helm_repository, where external_dependencies_patterns attribute was non-importable.
  • Renamed attribute in artifactory_remote_maven_repository to remove duplication.
  • Added import tests and tests for the modified fields.

@danielmkn danielmkn marked this pull request as ready for review February 16, 2023 01:38
alexhung
alexhung previously approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@alexhung alexhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Couple of minor, non-blocking suggestions

@danielmkn danielmkn requested a review from alexhung February 16, 2023 17:57
Turhsus
Turhsus approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@Turhsus Turhsus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmkn danielmkn merged commit b50252d into master Feb 16, 2023
@danielmkn danielmkn deleted the PTRENG-4591-import-tests-local-repo branch February 16, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexhung alexhung alexhung approved these changes

@Turhsus Turhsus Turhsus approved these changes

@mritunjaykumar mritunjaykumar Awaiting requested review from mritunjaykumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielmkn @alexhung @Turhsus @jfrogsolutioncicd