Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user password validation #1032

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Conversation

alexhung
Copy link
Member

Fixes #1031

  • Fix password validation being performed for interpolated value before it is 'known'. Due to Terraform limitation, validation mechanisms don't work on interpolated value which is unknown until create/read/update/delete stage. Now the resource validates password using regular validation mechanism when it is configured as plan text, or validate just prior to creating or updating the resource. This means when using interpolated value, terraform validate or terraform plan won't report error if value is invalid.
  • Make password validation logic more robust.

alexhung added 2 commits July 19, 2024 11:44
So it works with interpolated value as well

Also fix validation logic to work with non-contiguous patterns. For example,  for 2 min upper case instead of matching 'AA' now also match 'AbA'.
@alexhung alexhung added the bug Something isn't working label Jul 19, 2024
@alexhung alexhung marked this pull request as ready for review July 19, 2024 21:21
@alexhung alexhung requested a review from danielmkn as a code owner July 19, 2024 21:21
@alexhung alexhung merged commit 8f67247 into master Jul 22, 2024
2 checks passed
@alexhung alexhung deleted the GH-1031-fix-managed-user-validation branch July 22, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants