Support for downloading scan resources from an external repository #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory in Artifactory, instead of JFrog's repository.
asafgabai
added
improvement
github-actions
bot
removed
safe to test
asafgabai
changed the title
asafgabai
commented
Nov 2, 2023
Or-Geva
suggested changes
Nov 6, 2023
src/main/java/com/jfrog/ide/idea/configuration/ServerConfigImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jfrog/ide/idea/ui/configuration/JFrogGlobalConfiguration.java
Outdated
Show resolved
Hide resolved
asafgabai
commented
Nov 9, 2023
src/main/java/com/jfrog/ide/idea/ui/configuration/JFrogGlobalConfiguration.form
Outdated
Show resolved
Hide resolved
Or-Geva
suggested changes
Nov 9, 2023
There was a problem hiding this comment.
We can add to the GHA yaml the JFROG_IDE_TEST_EXTERNAL_RESOURCES_REPO env var as plain text.
Make sure that we also update https://github.com/jfrog/documentation with the new readme changes.
src/test/java/com/jfrog/ide/idea/integration/ExternalResourcesRepoIntegrationTests.java
Outdated
Show resolved
Hide resolved
yahavi
suggested changes
Nov 9, 2023
src/test/java/com/jfrog/ide/idea/integration/ExternalResourcesRepoIntegrationTests.java
Outdated
Show resolved
Hide resolved
src/test/java/com/jfrog/ide/idea/integration/ExternalResourcesRepoIntegrationTests.java
Outdated
Show resolved
Hide resolved
src/test/java/com/jfrog/ide/idea/integration/ExternalResourcesRepoIntegrationTests.java
Outdated
Show resolved
Hide resolved
src/test/java/com/jfrog/ide/idea/integration/ExternalResourcesRepoIntegrationTests.java
Outdated
Show resolved
Hide resolved
src/test/java/com/jfrog/ide/idea/integration/ExternalResourcesRepoIntegrationTests.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jfrog/ide/idea/ui/configuration/JFrogGlobalConfiguration.java
Outdated
Show resolved
Hide resolved
yahavi
reviewed
Nov 9, 2023
asafgabai
added
the
safe to test
github-actions
bot
removed
the
safe to test
asafgabai
added
the
safe to test
github-actions
bot
removed
the
safe to test
asafgabai
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to download scan resources from a custom repository in Artifactory, instead of JFrog's repository.