Webview upgrade and fixes #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… details view is first opened.
… details view is first opened.
asafgabai
added
the
safe to test
asafgabai
added
safe to test
Or-Geva
reviewed
Aug 7, 2023
| @@ -19,22 +19,18 @@ | |||
| public class WebviewManager implements Disposable { | |||
| private final JBCefBrowser jbCefBrowser; | |||
| public EventManager eventManager; | |||
| private boolean schemeHandlerRegistered = false; | |||
There was a problem hiding this comment.
Suggested change
| private boolean schemeHandlerRegistered = false; | |
| private boolean schemeHandlerRegistered; |
There was a problem hiding this comment.
I know it's not a must, but it makes it more clear that it's on purpose, especially when looking for a property's usages.
Or-Geva
reviewed
Aug 7, 2023
Or-Geva
reviewed
Aug 7, 2023
asafgabai
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded JFrog IDE Webview to v0.2.2.
Fixed IntelliJ crash on startup (the bug was not released).
Fixed issue not shown when the issue details view is first opened (the bug was not released).
Fixed jumping to the wrong place in the code (the bug was not released).