Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply allow-partial-results on IsDirectDependency check in scan-repository #784

Merged
merged 8 commits into from
Nov 11, 2024
Merged

Apply allow-partial-results on IsDirectDependency check in scan-repository #784

merged 8 commits into from
Nov 11, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Nov 7, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

This change support the new 'allow-partial-results' support in Yarn V1 dependencies map construction:
jfrog/build-info-go#282
jfrog/jfrog-cli-security#229

@eranturgeman eranturgeman changed the title bla Apply allow-partial-results on IsDirectDependency check in scan-repository Nov 7, 2024
@eranturgeman eranturgeman mentioned this pull request Nov 10, 2024
Merged
4 tasks
@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
attiasas
attiasas reviewed Nov 10, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, check out my comment

scanrepository/scanrepository.go Outdated Show resolved Hide resolved
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Nov 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

@eranturgeman eranturgeman merged commit ea2b0b6 into jfrog:dev Nov 11, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas left review comments

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eranturgeman @attiasas