Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scan-and-fix-repos faulty checkout #437

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Fix scan-and-fix-repos faulty checkout #437

merged 3 commits into from
Aug 14, 2023

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Aug 14, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

There was a checkout in an early stage before cloning the repository which caused an error when we only download the source code
Fix:
Move the checkout to target branch right after the clone operation.

@EyalDelarea EyalDelarea temporarily deployed to frogbot August 14, 2023 10:42 — with GitHub Actions Inactive
@EyalDelarea EyalDelarea added safe to test Approve running integration tests on a pull request bug Something isn't working labels Aug 14, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 14, 2023
@EyalDelarea EyalDelarea changed the title Move checkout to after clone Fix premature checkout Aug 14, 2023
@EyalDelarea EyalDelarea marked this pull request as ready for review August 14, 2023 12:57
@EyalDelarea EyalDelarea requested a review from sverdlov93 August 14, 2023 12:57
@EyalDelarea EyalDelarea linked an issue Aug 14, 2023 that may be closed by this pull request
Regression for "scan-and-fix-repos" in Azure DevOps server since version 2.11.5 #436
Closed
@EyalDelarea EyalDelarea changed the title Fix premature checkout Fix scan-and-fix-repos faulty checkout Aug 14, 2023
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Aug 14, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 14, 2023
@github-actions
Copy link
Contributor

@EyalDelarea EyalDelarea merged commit 1021885 into jfrog:dev Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 Awaiting requested review from sverdlov93

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression for "scan-and-fix-repos" in Azure DevOps server since version 2.11.5
1 participant
@EyalDelarea