-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip install in dependencies map calculation if requested #277
Merged
eyalbe4
merged 6 commits into
jfrog:dev
from
eranturgeman:skip-install-in-npm-dep-map-calc
Sep 30, 2024
Merged
Skip install in dependencies map calculation if requested #277
eyalbe4
merged 6 commits into
jfrog:dev
from
eranturgeman:skip-install-in-npm-dep-map-calc
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by user, even when it is necessary
eranturgeman
temporarily deployed
to
frogbot
September 25, 2024 12:19 — with
GitHub Actions
Inactive
eranturgeman
had a problem deploying
to
frogbot
September 25, 2024 12:21 — with
GitHub Actions
Failure
eranturgeman
temporarily deployed
to
frogbot
September 25, 2024 13:15 — with
GitHub Actions
Inactive
eranturgeman
added
improvement
Automatically generated release notes
and removed
ignore for release
Automatically generated release notes
labels
Sep 25, 2024
eranturgeman
changed the title
Skip install and dependencies map calc if requested
Skip install in dependencies map calculation if requested
Sep 25, 2024
This was referenced Sep 25, 2024
eyalbe4
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's create PRs for the jfrog-cli-core and jfrog-cli project, to make sure the tests there pass following this change.
eranturgeman
temporarily deployed
to
frogbot
September 30, 2024 11:51 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to NPM installation process when calculating dependencies map.
We currently add a new ability to skip installation of a project if requested by the user.
This new functionality will be available through Frogbot and will currently apply only to Yarn and NPM (for WalkMe POC)
The changes reflected here are only in NPM files due to the way NPM dependencies map calculation is performed. In the near future we opt to re-write this logic and take the installation logic to cli-security and leave only the map construction in build-info-go.
Tests were added as well.
The new logic is as follows: