Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #113: Refactor getSitePackagesPath to use python discovery #114

Closed
wants to merge 1 commit into from
Closed

Fix #113: Refactor getSitePackagesPath to use python discovery #114

wants to merge 1 commit into from

Conversation

rvodden
Copy link

@rvodden rvodden commented Oct 24, 2022

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@github-actions
Copy link

github-actions bot commented Oct 24, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@rvodden
Copy link
Author

rvodden commented Oct 24, 2022

I have read the CLA Document and I hereby sign the CLA

@talarian1
Copy link
Contributor

Hi @rvodden, thanks a lot for your contribution.
I suggest we will wait with those changes, as for Poetry 1.2 and above the file 'direct_url.json' is not created anymore.
You can see this discussion for more details.
The only usage for the getSitePackagesPath logic is getting those files.
Sorry for the inconvenience and thanks again!

virtualEnvPath, errorOut, _, err := gofrogcmd.RunCmdWithOutputParser(installCmd, true, &virtualEnvNameParser)
func getSitePackagesPath() (sitePackagesPath string, err error) {

siteCmd := utils.NewCommand("poetry", "run", []string{"python", "-c", "import sysconfig; print(sysconfig.get_paths()['purelib']])"})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
siteCmd := utils.NewCommand("poetry", "run", []string{"python", "-c", "import sysconfig; print(sysconfig.get_paths()['purelib']])"})
siteCmd := utils.NewCommand("poetry", "run", []string{"python", "-c", "import sysconfig; print(sysconfig.get_paths()['purelib'])"})

@rvodden
Copy link
Author

rvodden commented Oct 24, 2022

Hi @rvodden, thanks a lot for your contribution.
I suggest we will wait with those changes, as for Poetry 1.2 and above the file 'direct_url.json' is not created anymore.
You can see this discussion for more details.
The only usage for the getSitePackagesPath logic is getting those files.
Sorry for the inconvenience and thanks again!

aha great! I must admit i was thinking of authoring a poetry plugin which would output buildinfo... would that be interesting as an alternative to having to install jf-cli ?

@talarian1
Copy link
Contributor

Thanks again for your interest in this, and for your effort.
I'm closing this for now, as we discussed here we will need a new implementation to solve this issue.

@talarian1 talarian1 closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants