-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #113: Refactor getSitePackagesPath to use python discovery #114
Conversation
rvodden
commented
Oct 24, 2022
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Hi @rvodden, thanks a lot for your contribution. |
virtualEnvPath, errorOut, _, err := gofrogcmd.RunCmdWithOutputParser(installCmd, true, &virtualEnvNameParser) | ||
func getSitePackagesPath() (sitePackagesPath string, err error) { | ||
|
||
siteCmd := utils.NewCommand("poetry", "run", []string{"python", "-c", "import sysconfig; print(sysconfig.get_paths()['purelib']])"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
siteCmd := utils.NewCommand("poetry", "run", []string{"python", "-c", "import sysconfig; print(sysconfig.get_paths()['purelib']])"}) | |
siteCmd := utils.NewCommand("poetry", "run", []string{"python", "-c", "import sysconfig; print(sysconfig.get_paths()['purelib'])"}) |
aha great! I must admit i was thinking of authoring a poetry plugin which would output buildinfo... would that be interesting as an alternative to having to install jf-cli ? |
Thanks again for your interest in this, and for your effort. |