Support generating build-info for projects that use Poetry #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
talarian1
commented
Sep 13, 2022
talarian1
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
eyalbe4
requested changes
Sep 27, 2022
| dependencyName := dependency.Name + ":" + dependency.Version | ||
| dependencies[dependencyName] = maps.Keys(dependency.Dependencies) | ||
| } | ||
| return | ||
| } | ||
|
|
||
| func extractPoetryDependenciesFiles(srcPath string, cmdArgs []string, log utils.Log) (dependenciesFiles map[string]entities.Dependency, err error) { |
There was a problem hiding this comment.
- Let's add a description for this function, specifically describing the returned values and the structure of
dependenciesFiles. - Let's add a unit test for this function.
- I also suggest adding some more focused tests for the
getSitePackagesPathfunction.
There was a problem hiding this comment.
Tests will be added in following PR.
talarian1
force-pushed
the
add-poetry-commands
branch
from
56d49a2 to
4e39f47
Compare
eyalbe4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.