Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7573 - fix support in websocket for class path param types #7579

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

lachlan-roberts
Copy link
Contributor

Issue #7573

Add testing for path params with all primitive types and their class versions.
Fix PathParamIdentifier and JavaxWebSocketFrameHandlerFactory to make the path params work.

Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad for the new test cases.

@lachlan-roberts lachlan-roberts merged commit 514ceca into jetty-10.0.x Feb 16, 2022
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-7573-WebSocketPathParam branch February 16, 2022 22:44
@joakime joakime added this to the 12.0.x milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants