Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add distribution test for OpenID and fix issues with jetty-openid.xml #7546

Merged
merged 4 commits into from
Feb 16, 2022
Merged

Add distribution test for OpenID and fix issues with jetty-openid.xml #7546

merged 4 commits into from
Feb 16, 2022

Conversation

lachlan-roberts
Copy link
Contributor

Issue #7545

  • Add @Name annotations to OpenIdConfiguration constructor.
  • Add distribution test for jetty-openid so that any issues with the XML are detected.

gregw
gregw previously requested changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some niggles

jetty-openid/src/main/java/org/eclipse/jetty/security/openid/OpenIdConfiguration.java Outdated Show resolved Hide resolved
...s/test-webapps/test-openid-webapp/src/main/java/org/eclipse/jetty/test/openid/ErrorPage.java Outdated Show resolved Hide resolved
tests/test-webapps/test-openid-webapp/src/main/java/org/eclipse/jetty/test/openid/HomePage.java Outdated Show resolved Hide resolved
...s/test-webapps/test-openid-webapp/src/main/java/org/eclipse/jetty/test/openid/LoginPage.java Outdated Show resolved Hide resolved
.../test-webapps/test-openid-webapp/src/main/java/org/eclipse/jetty/test/openid/LogoutPage.java Outdated Show resolved Hide resolved
@lachlan-roberts lachlan-roberts requested a review from gregw February 8, 2022 05:02
@lachlan-roberts lachlan-roberts dismissed gregw’s stale review February 16, 2022 22:54

comments were already addressed

@lachlan-roberts lachlan-roberts merged commit 0f58246 into jetty-10.0.x Feb 16, 2022
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-7545-OpenIdXML branch February 16, 2022 22:54
@joakime joakime mentioned this pull request Feb 25, 2022
Closed
22 tasks
@joakime joakime mentioned this pull request Oct 6, 2022
Closed
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy olamy approved these changes

@gregw gregw Awaiting requested review from gregw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lachlan-roberts @olamy @gregw @joakime