#7461 Fix flakey ConnectionPoolTest.testQueuedRequestsDontOpenTooManyConnections: #7521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ential expirations Signed-off-by: Ludovic Orban <[email protected]>
gregw
previously approved these changes
Feb 3, 2022
sbordet
requested changes
Feb 10, 2022
jetty-client/src/test/java/org/eclipse/jetty/client/ConnectionPoolTest.java
Show resolved
Hide resolved
Signed-off-by: Ludovic Orban <[email protected]>
sbordet
approved these changes
Feb 14, 2022
lorban
deleted the
jetty-10.0.x-7461-fix-flakey-testQueuedRequestsDontOpenTooManyConnections
branch
22 tasks
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use less strict assertion for expiring pool to account for potential expirations. Since an expiration check is done by the pool every time a connection is released, it is entirely possible (and legal) that a bad scheduling would close some connections; hence the assertion must be relaxed to account for this in the expiring pool case.
Fixes #7461.