Fixed header cache for unknown values #11808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregw
added
Bug
sbordet
requested changes
May 19, 2024
| @@ -167,7 +167,8 @@ public class HttpParser | |||
| for (HttpHeader h : HttpHeader.values()) | |||
| { | |||
| HttpField httpField = new HttpField(h, UNMATCHED_VALUE); | |||
| map.put(httpField.toString(), httpField); | |||
| map.put(h + ": ", httpField); | |||
| map.put(h + ":", httpField); | |||
There was a problem hiding this comment.
Do we really want to cache the no-space-after-column case?
It's bad formatting by the client, so it deserves less efficiency?
There was a problem hiding this comment.
I added it in because I initially write a test that was just looking up "Content-Type:" (no space) and was surprised by the miss. But I will remove for now to just fix the issue and we can think about other optimizations separately.
sbordet
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid adding the unknown marker into the CACHE index. Issue introduced in #11661 fixing #11659