Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #11387: Reintroduce MultiPartCompliance.LEGACY in ee9/ee8 #11388

Merged
merged 29 commits into from
Feb 27, 2024
Merged

Issue #11387: Reintroduce MultiPartCompliance.LEGACY in ee9/ee8 #11388

merged 29 commits into from
Feb 27, 2024

Commits on Feb 7, 2024

  1. Issue #11387: Reintroduce MultiPartCompliance.LEGACY in ee9/ee8

    @joakime
    joakime committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e125ada View commit details
    Browse the repository at this point in the history

  2. Correcting javadoc

    @joakime
    joakime committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e7a92ca View commit details
    Browse the repository at this point in the history

  3. Updating MultiPartCaptureTest to ... 

    * Test with MultiPartFormData.Parser and MultiPart.Parser
* Enable all test cases
  * base64 behaviors modified to not auto-decode base64 content
  * forms submitted without `_charset_` part (some using a different
     charset than UTF-8, like `Shift_JIS`)
    @joakime
    joakime committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9120cfd View commit details
    Browse the repository at this point in the history

  4. Fixing checkstyle warning

    @joakime
    joakime committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9a7371f View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Re-enable Part-ContainsContents expectations

    @joakime
    joakime committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    542f3ff View commit details
    Browse the repository at this point in the history

  2. Rename MultiPartCompliance.NO_CRLF_AFTER_PREAMBLE to WHITESPACE_AFTER… 

    …_PREAMBLE to fit spec better
    @joakime
    joakime committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    744e382 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Make ee9/ee8 legacy parser use legacy tokenization

    @joakime
    joakime committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    a2f2583 View commit details
    Browse the repository at this point in the history

  2. Testing ee9/ee8 legacy parser base64 auto-decoding behaviors

    @joakime
    joakime committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    f82683a View commit details
    Browse the repository at this point in the history

  3. Cleanup jetty-test-multipart class naming

    @joakime
    joakime committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    c018cae View commit details
    Browse the repository at this point in the history

  4. Adding ee10 tests against raw multipart examples

    @joakime
    joakime committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    56652f1 View commit details
    Browse the repository at this point in the history

  5. Adding shorter whitespace multipart test

    @joakime
    joakime committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    ebd109d View commit details
    Browse the repository at this point in the history

  6. Adding jetty-core version of failing ee10 tests

    @joakime
    joakime committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    eba54dd View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Fixing checkstyle

    @joakime
    joakime committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    367efd8 View commit details
    Browse the repository at this point in the history

  2. Fixed missed notification for CR content in case of 1 chunk ending wi… 

    …th CR and the next chunk ending with LF.

Removed internal unused class MultiPartParser.

Signed-off-by: Simone Bordet <[email protected]>
    @sbordet
    sbordet committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    9321e5e View commit details
    Browse the repository at this point in the history

  3. Update test case, as there is now an extra notifyCRContent event

    @joakime
    joakime committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    6e80cb7 View commit details
    Browse the repository at this point in the history

  4. Update test case, as there is now an extra notifyCRContent event

    @joakime
    joakime committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    18a0acd View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Adding MultiPartCompliance.Violation events 

    + in MultiPart.Parser
+ in MultiPartFormData.Parser
    @joakime
    joakime committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    edabdb5 View commit details
    Browse the repository at this point in the history

  2. Rename WHITESPACE_AFTER_PREAMBLE to WHITESPACE_BEFORE_BOUNDARY 

    + lenient mode behavior
+ new name fits violation better
+ new tests
    @joakime
    joakime committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    d56838e View commit details
    Browse the repository at this point in the history

  3. Notifying WHITESPACE_BEFORE_BOUNDARY 

    + adding violation to MultiPart.Parser.parseHeaderStart
    @joakime
    joakime committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    65bba39 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. some simple cleanup of new ee9 code

    @joakime
    joakime committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    d464627 View commit details
    Browse the repository at this point in the history

  2. Fix comment

    @joakime
    joakime committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    b9c1860 View commit details
    Browse the repository at this point in the history

  3. Cleaning up @disabled tests

    @joakime
    joakime committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    5cdef49 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Merge remote-tracking branch 'origin/jetty-12.0.x' into fix/12.0.x/mu… 

    …ltipart-legacy-parser
    @joakime
    joakime committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    3f84156 View commit details
    Browse the repository at this point in the history

  2. Cleanup from merge

    @joakime
    joakime committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    f21752f View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Changes from review

    @joakime
    joakime committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    30c7c35 View commit details
    Browse the repository at this point in the history

  2. Changes from review

    @joakime
    joakime committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    c09e017 View commit details
    Browse the repository at this point in the history

  3. Changes from review

    @joakime
    joakime committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    b2e8dee View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Cosmetics. 

    Signed-off-by: Simone Bordet <[email protected]>
    @sbordet
    sbordet committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    cc745c7 View commit details
    Browse the repository at this point in the history

  2. More cosmetics. 

    Signed-off-by: Simone Bordet <[email protected]>
    @sbordet
    sbordet committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    460b83e View commit details
    Browse the repository at this point in the history