Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MavenLocalRepoFileInitializerTest#testDownloadSnapshotRepo depends on possible missing external resources #7315

Closed
olamy opened this issue Dec 20, 2021 · 11 comments · Fixed by #9279
Assignees
Labels
Bug For general bugs on Jetty side Build Stale For auto-closed stale issues and pull requests Test

Comments

@olamy
Copy link
Member

olamy commented Dec 20, 2021

the test MavenLocalRepoFileInitializerTest#testDownloadSnapshotRepo depends on downloading snapshot jars from https://oss.sonatype.org/content/repositories/jetty-snapshots/ with hardcoded version 10.0.0-SNAPSHOT.
the test should be rewrite to use https://www.mojohaus.org/mrm/mrm-maven-plugin/ and download current installed version.

@olamy olamy added Bug For general bugs on Jetty side Test Build labels Dec 20, 2021
@olamy olamy self-assigned this Dec 20, 2021
@joakime
Copy link
Contributor

joakime commented Dec 20, 2021

The whole point of that test is to ensure that the start.jar follows maven convention for snapshot metadata.

@joakime
Copy link
Contributor

joakime commented Dec 20, 2021

We've filed an issue with oss.sonatype.org btw to address the missing jetty-snapshots repo

@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Dec 21, 2022
@github-actions
Copy link

This issue has been closed due to it having no activity.

@joakime
Copy link
Contributor

joakime commented Jan 21, 2023

oss-sonatype has restored the missing jetty-snapshots repo

@olamy
Copy link
Member Author

olamy commented Feb 1, 2023

need to be fixed as after a cleanup of snapshots in oss.sonatype.org builds are now failing

@olamy olamy reopened this Feb 1, 2023
@joakime
Copy link
Contributor

joakime commented Feb 1, 2023

We should probably look into having a repo.webtide.net that is publicly exposed and has our SNAPSHOTS on it.

@jmcc0nn3ll thoughts?

@joakime
Copy link
Contributor

joakime commented Feb 1, 2023

I'm reopening this.
We should either find a reliable way to still perform this test, or remove it.

@joakime joakime reopened this Feb 1, 2023
@olamy
Copy link
Member Author

olamy commented Feb 1, 2023

I would prefer to use https://github.com/mojohaus/mrm which local installed snapshots as part of the build.
no need of external resource.
No urgent for now but need to be done.

@github-actions github-actions bot removed the Stale For auto-closed stale issues and pull requests label Feb 2, 2023
Copy link

github-actions bot commented Feb 2, 2024

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Feb 2, 2024
@joakime
Copy link
Contributor

joakime commented Feb 2, 2024

Closing, as we haven't seen this issue in quite a while.

@joakime joakime closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side Build Stale For auto-closed stale issues and pull requests Test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants