Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jetty-10/11 work against slf4j-api 1.7.30 in addition to 2.0.0 #6385

Closed
janbartel opened this issue Jun 10, 2021 · 6 comments
Closed

Make jetty-10/11 work against slf4j-api 1.7.30 in addition to 2.0.0 #6385

janbartel opened this issue Jun 10, 2021 · 6 comments
Labels
Bug For general bugs on Jetty side

Comments

@janbartel
Copy link
Contributor

jetty10/11

Currently, jetty builds against, and distributes slf4j-api version 2.0.0-alpha1. However, we have some users who need to run against the same slf4j version as older releases, which was slf4j-api 1.7.30.

We should modify the jetty-slf4j-logging implementation to also work against 1.7.30, build against 1.7.30, but distribute 2.0.0-alpha1 with jetty.home.

@janbartel janbartel added the Bug For general bugs on Jetty side label Jun 10, 2021
@janbartel
Copy link
Contributor Author

@joakime comments?

@olamy
Copy link
Member

olamy commented Jun 10, 2021

@joakime our org.slf4j.spi.SLF4JServiceProvider implementation in a separate module?

@joakime
Copy link
Contributor

joakime commented Jun 10, 2021

I think this is doable on the jetty-slf4j-logging side.
Have to be careful with the jpms testing stuff though.

@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Jun 11, 2022
@BLUERAYDAN BLUERAYDAN mentioned this issue Jun 11, 2022
@sbordet
Copy link
Contributor

sbordet commented Jun 13, 2022

Do we still need to support this?

@github-actions github-actions bot removed the Stale For auto-closed stale issues and pull requests label Jun 14, 2022
@joakime
Copy link
Contributor

joakime commented Jun 14, 2022

No, just downgrading your slf4j-api version that you use with jetty is sufficient.
There's no code changes necessary.

@joakime joakime closed this as completed Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

No branches or pull requests

4 participants