Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coalesce HTTP/2 HEADERS and DATA writes #2423

Closed
sbordet opened this issue Apr 8, 2018 · 4 comments
Closed

Coalesce HTTP/2 HEADERS and DATA writes #2423

sbordet opened this issue Apr 8, 2018 · 4 comments
Assignees

Comments

@sbordet
Copy link
Contributor

sbordet commented Apr 8, 2018

From the discussion in #2420.

HttpTransport.send() provides the headers and first content chunk.

Introduce a pseudo frame type that contains the info for headers and data. At generation create the headers frame, then the data frame prefix (into the same leased buffer) then it adds the sliced data buffer.

If send only has headers then only send headers. If send only has data then send only data. But if it had both then send both!

It will save a lot and the other end will be faster as well as the headers and data will not be split by writes nor interleaved with other frames.

@stale
Copy link

stale bot commented Nov 20, 2019

This issue has been automatically marked as stale because it has been a full year without activit. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Nov 20, 2019
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Nov 21, 2019
@sbordet sbordet self-assigned this Nov 21, 2019
@stale
Copy link

stale bot commented Nov 21, 2020

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Nov 21, 2020
@sbordet
Copy link
Contributor Author

sbordet commented Nov 21, 2020

See also #3766.

@stale stale bot removed the Stale For auto-closed stale issues and pull requests label Nov 21, 2020
@sbordet
Copy link
Contributor Author

sbordet commented Nov 21, 2020

Fixed with #5222.

@sbordet sbordet closed this as completed Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant