diff --git a/jetty-server/src/main/java/org/eclipse/jetty/server/Request.java b/jetty-server/src/main/java/org/eclipse/jetty/server/Request.java index 43f38a6e40e0..777eb1394884 100644 --- a/jetty-server/src/main/java/org/eclipse/jetty/server/Request.java +++ b/jetty-server/src/main/java/org/eclipse/jetty/server/Request.java @@ -1435,8 +1435,10 @@ public void onCompleted() RequestLog requestLog = httpChannel.getRequestLog(); if (requestLog != null) { - // Don't allow pulling more parameters + // Don't allow pulling more parameters from request body content _contentParamsExtracted = true; + if (_contentParameters == null) + _contentParameters = NO_PARAMS; // Reset the status code to what was committed MetaData.Response committedResponse = getResponse().getCommittedMetaData(); diff --git a/jetty-server/src/test/java/org/eclipse/jetty/server/RequestLogTest.java b/jetty-server/src/test/java/org/eclipse/jetty/server/RequestLogTest.java index 440650475e1d..f00434151215 100644 --- a/jetty-server/src/test/java/org/eclipse/jetty/server/RequestLogTest.java +++ b/jetty-server/src/test/java/org/eclipse/jetty/server/RequestLogTest.java @@ -34,6 +34,8 @@ import org.eclipse.jetty.util.component.LifeCycle; import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.ValueSource; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -145,8 +147,9 @@ public void testNormalGetRequest() throws Exception * Test an unread HTTP/1.1 POST, it has valid body content, the dispatched Handler on the server doesn't read the POST body content. * The RequestLog accidentally attempts to read the Request body content due to the use of Request.getParameterNames() API. */ - @Test - public void testNormalPostFormRequest() throws Exception + @ParameterizedTest + @ValueSource(strings = {"/hello", "/hello?a=b"}) + public void testNormalPostFormRequest(String requestPath) throws Exception { Server server = null; try @@ -179,7 +182,7 @@ public void testNormalPostFormRequest() throws Exception byte[] bufForm = form.toString().getBytes(UTF_8); StringBuilder req = new StringBuilder(); - req.append("POST /hello HTTP/1.1\r\n"); + req.append("POST ").append(requestPath).append(" HTTP/1.1\r\n"); req.append("Host: ").append(baseURI.getRawAuthority()).append("\r\n"); req.append("Content-Type: ").append(MimeTypes.Type.FORM_ENCODED).append("\r\n"); req.append("Content-Length: ").append(bufForm.length).append("\r\n"); @@ -213,7 +216,10 @@ public void testNormalPostFormRequest() throws Exception assertThat("Body Content", bodyContent, containsString("Got POST to /hello")); String reqlog = requestLogLines.poll(5, TimeUnit.SECONDS); - assertThat("RequestLog", reqlog, containsString("method:POST|uri:/hello|paramNames.size:0|status:200")); + int querySize = 0; + if (requestPath.contains("?")) + querySize = 1; // assuming that parameterized version only has 1 query value + assertThat("RequestLog", reqlog, containsString("method:POST|uri:/hello|paramNames.size:" + querySize + "|status:200")); } } finally