Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lamb optimizer warning in pytorch 1.6 #143

Closed
Laksh1997 opened this issue Jun 25, 2020 · 6 comments
Closed

Lamb optimizer warning in pytorch 1.6 #143

Laksh1997 opened this issue Jun 25, 2020 · 6 comments

Comments

@Laksh1997
Copy link

Hi I'm getting this deprecated warning in pytorch 1.6 for Lamb:


  | 2020-06-25T01:58:41.682+01:00 | add_(Tensor other, *, Number alpha) (Triggered internally at /opt/conda/conda-bld/pytorch_1592982553767/work/torch/csrc/utils/python_arg_parser.cpp:766.)
-- | -- | --
  | 2020-06-25T01:58:41.682+01:00 | exp_avg.mul_(beta1).add_(1 - beta1, grad)
  | 2020-06-25T01:58:41.682+01:00 | 2020-06-25T00:58:41 - WARNING - /opt/conda/envs/py36/lib/python3.6/site-packages/torch_optimizer/lamb.py:120: UserWarning: This overload of add_ is deprecated:
  | 2020-06-25T01:58:41.682+01:00 | add_(Number alpha, Tensor other)
  | 2020-06-25T01:58:41.682+01:00 | Consider using one of the following signatures instead:
  | 2020-06-25T01:58:41.682+01:00 | add_(Tensor other, *, Number alpha) (Triggered internally at /opt/conda/conda-bld/pytorch_1592982553767/work/torch/csrc/utils/python_arg_parser.cpp:766.)
  | 2020-06-25T01:58:41.682+01:00 | exp_avg.mul_(beta1).add_(1 - beta1, grad)


@ghost
Copy link

ghost commented Jul 31, 2020

Hi. @Laksh1997

I would like to know if the LAMB optimizer works properly with Pytorch 1.6.

Many thanks for your help in advance !!!

@jettify
Copy link
Owner

jettify commented Aug 3, 2020

Just executed test suite with pytorch 1.6, had to fix lookahead optimizer but all other tests are green.

@jettify
Copy link
Owner

jettify commented Aug 3, 2020

As for warning it is easy to fix and should not have any influence over results. Gonna fix it soon also happy to merge PRs with fixes.

@ghost
Copy link

ghost commented Aug 3, 2020

@jettify Hi~
Many thanks for your feedback!
And thanks for your amazing job!

@jettify
Copy link
Owner

jettify commented Aug 3, 2020

Fixed in #163 going to do PyPI release relatively soon.

@jettify jettify closed this as completed Aug 3, 2020
@jettify
Copy link
Owner

jettify commented Aug 11, 2020

New release on PyPI https://pypi.org/project/torch-optimizer/0.0.1a15/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants