Created echo color fix branch #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wenlin <[email protected]>
jetstack-bot
added
the
size/S
Added formating to echo command output
jetstack-bot
added
size/M
j-fuentes
reviewed
Jul 28, 2021
| @@ -43,12 +44,20 @@ func echoHandler(w http.ResponseWriter, r *http.Request) { | |||
| } | |||
|
|
|||
| // print the data sent to the echo server to the console | |||
| fmt.Printf("-- %s %s -> created %d\n", r.Method, r.URL.Path, http.StatusCreated) | |||
|
|
|||
| // this should be in color1 | |||
There was a problem hiding this comment.
you can remove these // this should be color ... comments
j-fuentes
reviewed
Jul 28, 2021
Comment on lines
+52
to
+57
| for i, r := range payload.DataReadings { | ||
| if i%2 == 0 { | ||
| color.Yellow("Reading:\n%s\n", prettyPrint(r)) | ||
| } else { | ||
| color.Cyan("Reading:\n%s\n", prettyPrint(r)) | ||
| } |
There was a problem hiding this comment.
nit. I'd rework this a bit to avoid repetition and always print in the same line:
for i, r := range payload.DataReadings {
c := color.New(color.FgYellow)
if i%2==0 {
c = color.New(color.Cyan)
}
color.New(c).Fprintf("#%s:\n%s\n", i, prettyPrint(r))
}
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds colours to echo sever output.
fixes #242
Signed-off-by: wenlin [email protected]