Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual marker analysis fails to start when JLS read still updating #103

Closed
mliberty1 opened this issue Oct 19, 2020 · 1 comment
Closed

Dual marker analysis fails to start when JLS read still updating #103

mliberty1 opened this issue Oct 19, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@mliberty1
Copy link
Member

mliberty1 commented Oct 19, 2020

Version: 0.9.2
Platform: All

Description
JLS read can take a long time, as noted in #102. If you add dual markers and start an analysis, such as Histogram, while the waveform is still updating, the analysis dialog never appears.

Expected Behavior
The analysis dialog should eventually appear.

Developer Notes
The analysis is timing out here. This timeout kills the reading device permanently without informing the user or attempting to recover. The 10-second timeout is too fast given that it does not account for the queued updates already processing.

Source: ps_Water on the forum.

@mliberty1 mliberty1 added the bug Something isn't working label Oct 19, 2020
@mliberty1
Copy link
Member Author

Tested as fixed in 1.0.16. Good luck being fast enough to add markers while the JLS v2 file is loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant