From ecf3c9dcb3e97db5a5018d8ec24f1915b846639b Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Sun, 9 Feb 2020 12:09:28 +0100 Subject: [PATCH 1/4] chore: run GH Actions on windows as well --- .github/workflows/nodejs.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 60a4c64e0023..cefa00211222 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -56,8 +56,7 @@ jobs: matrix: # https://github.com/actions/setup-node/issues/27 node-version: [8.17.0, 10.x, 12.x, 13.x] - # Windows tests are failing for whatever reason, so just do linux and mac for now - os: [ubuntu-latest, macOS-latest] + os: [ubuntu-latest, macOS-latest, windows-latest] runs-on: ${{ matrix.os }} steps: From 10d8d3ff2b093e53138cb69134b70595702cdf98 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Tue, 11 Feb 2020 16:12:44 +0100 Subject: [PATCH 2/4] maybe set som git stuff? --- .github/workflows/nodejs.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index cefa00211222..48b16d5c71cf 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -60,6 +60,12 @@ jobs: runs-on: ${{ matrix.os }} steps: + - name: Set git config + shell: bash + run: | + git config --global core.autocrlf false + git config --global core.symlinks true + if: runner.os == windows-latest - uses: actions/checkout@v2 - name: Get yarn cache id: yarn-cache From 064df66d99e08b3b24f2fbd5f68842f4b8656d1f Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Tue, 11 Feb 2020 16:14:18 +0100 Subject: [PATCH 3/4] syntax? --- .github/workflows/nodejs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 48b16d5c71cf..bd9b043c7fef 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -65,7 +65,7 @@ jobs: run: | git config --global core.autocrlf false git config --global core.symlinks true - if: runner.os == windows-latest + if: runner.os == 'windows-latest' - uses: actions/checkout@v2 - name: Get yarn cache id: yarn-cache From e6fe42ef1140fe4523e4c78ef01b9af20c8d7015 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Tue, 11 Feb 2020 16:16:38 +0100 Subject: [PATCH 4/4] this? --- .github/workflows/nodejs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index bd9b043c7fef..556a26a33542 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -65,7 +65,7 @@ jobs: run: | git config --global core.autocrlf false git config --global core.symlinks true - if: runner.os == 'windows-latest' + if: runner.os == 'Windows' - uses: actions/checkout@v2 - name: Get yarn cache id: yarn-cache