-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Align snapshots in jest-matcher-utils #8957
Conversation
@jeysal Continuing our discussion from #8959 what do you think about this method to serialize aligned snapshots of diffs and reports when matcher fails: import convertAnsi1 from '../../../pretty-format/src/plugins/ConvertAnsi1';
expect.addSnapshotSerializer(convertAnsi1);
|
Codecov Report
@@ Coverage Diff @@
## master #8957 +/- ##
=========================================
- Coverage 63.98% 63.9% -0.08%
=========================================
Files 276 277 +1
Lines 11638 11652 +14
Branches 2859 2859
=========================================
Hits 7446 7446
- Misses 3562 3576 +14
Partials 630 630
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Display colors concisely and clearly so you can review future changes quickly and confidently
Test plan
index.test.ts
replace 2toMatchSnapshot
assertions withtoBe
and more precise criterionindex.test.ts.snap
update 11 which are fromtoThrowErrorMatchingSnapshot
assertionsprintDiffOrStringify.test.ts.snap
update 6