-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for transforming runner #8854
Conversation
@SimenB e2e for |
After much tedious debugging the culprit seems to be
I'll try to dig into |
96b0aae
to
cc09d52
Compare
Codecov Report
@@ Coverage Diff @@
## master #8854 +/- ##
==========================================
+ Coverage 64.73% 64.73% +<.01%
==========================================
Files 277 277
Lines 11707 11708 +1
Branches 2874 2875 +1
==========================================
+ Hits 7578 7579 +1
Misses 3512 3512
Partials 617 617
Continue to review full report at Codecov.
|
6bb4a96
to
59ff30c
Compare
1ac7900
to
cb5b4a7
Compare
cb5b4a7
to
7c28c0f
Compare
bb7d5e5
to
a71ce84
Compare
Rebased it against the current master Not sure what's the problem with CI, it's only failing for macOS, and surprisingly enough I ran it against master in my local and I got the same.
|
Also, could you rebase (or just merge in master) again? Conflicts with #8751 |
I'll rebase it |
a71ce84
to
61dab1f
Compare
"dependencies": { | ||
"@babel/preset-env": "^7.0.0", | ||
"@babel/preset-typescript": "^7.0.0", | ||
"jest-environment-node": "^26.6.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"jest-environment-node": "^26.6.2" | |
"jest-environment-node": "file:../../../packages/jest-environment-node" |
does that work? to avoid hard-coding a version
do we even need these dependencies? I don't see yarn
being run in here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check, the changes were made before yarn berry came in, with the file:
protocol I'll see if it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works with the file:
protocol in my local, updating in both here and the jest-env
PR
Co-authored-by: Simen Bekkhus <[email protected]>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Allow
jest-runner
to be transformable.Part of #8810
Test plan
Have added test case for the change