-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jest-circus) correct concurrent event ordering #15381
Open
madcapnmckay
wants to merge
13
commits into
jestjs:main
Choose a base branch
from
madcapnmckay:jest-circus-concurrent-event-ordering2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(jest-circus) correct concurrent event ordering #15381
madcapnmckay
wants to merge
13
commits into
jestjs:main
from
madcapnmckay:jest-circus-concurrent-event-ordering2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…end of the sync loop
This reverts commit df577c2.
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
madcapnmckay
changed the title
Jest circus concurrent event ordering2
fix(jest-circus) correct concurrent event ordering
Nov 15, 2024
@SimenB - the failures on the checks seem to be affecting other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note this is a re-raise of an old PR that I previously let go stale.
I'm unsure if this is a major, minor, or patch change. It does not change the API, but it changes the order of events emitted from
jest-circus
. Please advise.This fixes the issue documented here
When using
test.concurrent
events such astest_start
,test_started
, andtest_fn_start
are dispatched after the body of the test is executed. This is due to the_runTest
function not being executed as part of the parallel execution runner; instead, it was executed synchronously like non-concurrent tests.The solution was to use _runTest within startTestsConcurrently() and then wait for that process to complete instead of replacing the
test.fn
as was being done before.I also added a bunch of e2e tests for concurrent, this change most likely closes some other issues relating to
before/afterAll
.Test plan
953bbed700
yarn test packages/jest-circus/src/__tests__/baseTest.test.ts
to observe the broken snapshot content for the concurrent test.HEAD
and rerun the test. Note that the output has been reordered to match the expectation that the circus actions occur before and after the test execution.yarn jest e2e/__tests__/circusConcurrent.test.ts
andyarn jest e2e/__tests__/testRetries.test.ts
Note: at the time this is being raised
main
does not passyarn test
, I have confirmed that the same tests are failing before and after my change.