fix: mocking of getters/setters on automatically mocked classes #13391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/jest-mock/src/index.ts
Co-authored-by: Tom Mrazauskas <[email protected]>
…functions being mocked as accessor objects.
# Conflicts: # yarn.lock
…Mocker.spyOn() refactoring
staplespeter
changed the title
|
can you revert my revert (52d45be) then add the fix on top? should be easier to look at the fix that way 🙂 |
|
okay, I'll close this request off then, and start a new branch from the latest main to revert the revert |
|
thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new pull request to complete #13145, which was prematurely closed.