Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor tests + clean up unused code in SearchSource #12526

Merged
merged 16 commits into from
Mar 2, 2022
Merged

chore: refactor tests + clean up unused code in SearchSource #12526

merged 16 commits into from
Mar 2, 2022

Commits on Mar 2, 2022

  1. Remove unused code

    @brandon-leapyear
    brandon-leapyear committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    fabb7c6 View commit details
    Browse the repository at this point in the history

  2. Fix test to parametrize option name correctly

    @brandon-leapyear
    brandon-leapyear committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    0877839 View commit details
    Browse the repository at this point in the history

  3. Move general test out of win32-specific test block

    @brandon-leapyear
    brandon-leapyear committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    efc803d View commit details
    Browse the repository at this point in the history

  4. Avoid config global variable

    @brandon-leapyear
    brandon-leapyear committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    e440bea View commit details
    Browse the repository at this point in the history

  5. Destructure instead of getter

    @brandon-leapyear
    brandon-leapyear committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    3757a9e View commit details
    Browse the repository at this point in the history

  6. Replace .then with await

    @brandon-leapyear
    brandon-leapyear committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    6497d1b View commit details
    Browse the repository at this point in the history

  7. Unnest things

    @brandon-leapyear
    brandon-leapyear committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    99a292c View commit details
    Browse the repository at this point in the history

  8. Reformat

    @brandon-leapyear
    brandon-leapyear committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    c68f2b5 View commit details
    Browse the repository at this point in the history

  9. Pass initialOptions into findMatchingTests helper

    @brandon-leapyear
    brandon-leapyear committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    a80a2ea View commit details
    Browse the repository at this point in the history

  10. Break out initSearchSource helper

    @brandon-leapyear
    brandon-leapyear committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    6f66f69 View commit details
    Browse the repository at this point in the history

  11. Reformat

    @brandon-leapyear
    brandon-leapyear committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    7111219 View commit details
    Browse the repository at this point in the history

  12. Rewrite findMatchingTests helper

    @brandon-leapyear
    brandon-leapyear committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    988df3f View commit details
    Browse the repository at this point in the history

  13. Remove unnecessary sorting of static paths

    @brandon-leapyear
    brandon-leapyear committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    dc0e0df View commit details
    Browse the repository at this point in the history

  14. Reformat

    @brandon-leapyear
    brandon-leapyear committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    198744f View commit details
    Browse the repository at this point in the history

  15. Update tests to actually test correct code path 

    These tests test 'testRegex' and 'testMatch', which don't use
findMatchingTests at runtime, so this commit updates the tests to use
getTestPaths, which is the correct entrypoint for these options.
    @brandon-leapyear
    brandon-leapyear committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    9621b2e View commit details
    Browse the repository at this point in the history

  16. Remove support for findMatchingTests with no args

    @brandon-leapyear
    brandon-leapyear committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    53e4bb1 View commit details
    Browse the repository at this point in the history