Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use property initializer syntax in Jest codebase #7846

Closed
SimenB opened this issue Feb 10, 2019 · 6 comments · Fixed by #8117
Closed

Use property initializer syntax in Jest codebase #7846

SimenB opened this issue Feb 10, 2019 · 6 comments · Fixed by #8117

Comments

@SimenB
Copy link
Member

SimenB commented Feb 10, 2019

From #7844 (comment)

It'd be nice to avoid bind(this) and constructor assignments. We need to add https://babeljs.io/docs/en/babel-plugin-proposal-class-properties and go through the code to figure out where we could use it

@ghost
Copy link

ghost commented Mar 6, 2019

Hi @SimenB I'm interested in working in this issue! Where's a good place to start looking for breadcrumbs?

@natealcedo
Copy link

@peanutenthusiast If you're using vscode, you can start by using the global search command + shift + f and look for .bind(this). That should get the ball rolling

@SimenB
Copy link
Member Author

SimenB commented Mar 7, 2019

You can take a look at #7881 as well

@jeysal
Copy link
Contributor

jeysal commented Mar 14, 2019

Note that #8117 didn't change the unnecessary constructor assignments mentioned in the OP, just binds. (Good enough for me though, the binds are what's most annoying)

@SimenB
Copy link
Member Author

SimenB commented Mar 14, 2019

It's in now, so we can start using it, and fixing different parts as we come over them

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants