Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing newline after "no files changed" #5305

Closed
gaearon opened this issue Jan 14, 2018 · 7 comments
Closed

Missing newline after "no files changed" #5305

gaearon opened this issue Jan 14, 2018 · 7 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented Jan 14, 2018

I see this in Jest 22.0.6:

screen shot 2018-01-14 at 1 39 33 pm

To reproduce, you can clone next branch of create-react-app, run yarn in it, and then run yarn test.

@sachinmk27
Copy link
Contributor

Hi, I would like to take this up as my first issue. May I ?

@gaearon
Copy link
Contributor Author

gaearon commented Jan 14, 2018

Sure!

@sachinmk27
Copy link
Contributor

sachinmk27 commented Jan 14, 2018

Thanks for letting me do this. I think I have fixed it. It was a case of operator precedence. I followed the instructions in CONTRIBUTING.md, forked the repo, made the changes. And I found that running jest -o will run the required tests. All tests passed.
But I am unsure on how to proceed. Have I missed something ? Please help.

Here is a screenshot of running yarn test in create-react-app after making the changes.
screenshot from 2018-01-14 22-08-44

@rickhanlonii
Copy link
Member

Hey @sachinmk2, congrats on your first set of changes1

It sounds like the next step is to put in a pull request. When you create the PR you'll see there's a template with instructions for the next steps

@sachinmk27
Copy link
Contributor

Thanks @rickhanlonii .
I sent a pull request #5308. But one of the builds failed.
screenshot from 2018-01-15 00-02-07

I am using https://github.com/prettier/prettier in my visual code IDE. Is that responsible for the failed build ? Please tell me how to proceed.

@sachinmk27
Copy link
Contributor

Hi, all builds are passing. Thanks to @gaearon . What should i do next ?

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants