CustomConsole is missing many methods

[taion]

Ref https://github.com/facebook/relay/pull/1857/files#r119980384

Would it make sense for CustomConsole to implement (or stub) some of the more advanced console methods? Might be nicer than having to sniff for support in various loggers to avoid erroring out in tests.

[thymikee]

It makes sense if you're willing to do so! :)

[sumnerevans]

@taion , @thymikee , which of the functions listed in the MDN Docs for Console need to be implemented? I can jump in to implementing them.

[taion]

group and groupCollapsed would be nice :D

[goksu]

Can someone point me to certain files that have references to said CustomConsole? I'd like to take on the item, but do need some familiarity on the code base before doing so. Thank you!

[thymikee]

@gtoprak The code sits mostly in here: https://github.com/facebook/jest/blob/master/packages/jest-util/src/Console.js. We basically extend Nodes console module and apply some logic to buffer the output.

[nicolasiensen]

What's wrong with the pull request submitted by @sumnerevans ? As far as I can see it is just waiting for code review.

[SimenB]

That PR is opened against a fork of Jest, not Jest itself

[binygal]

Can I help with this issue? Is it still waiting to fix? What exactly is still needed to be done?

[sumnerevans]

@binygal , @gtoprak , I worked on this over the summer for my internship with Kenzan. I am no longer at the company, so I am not communicating in any official capacity.

We had some trouble getting CLAs signed (corporate politics), so we didn't submit anything upstream. If you want, you can look at what I implemented. I give you permission to copy-paste what I did.

[SimenB]

#5514

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.