-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jest-config shouldn't import getType from matcher-utils #3528
Comments
I could pick this up if you want @thymikee. If it shouldn't use |
I think you could even copy the whole function for now. We just don't want @cpojer what do you think about extracting similar shared helper functions into |
This one should be jest-get-type or something? ;) |
We're OK with having a package for a single function? |
yes, this is JavaScript. |
sindresorhus style, yea |
Okay, coming right up! |
I was going through and replacing all the instances of getType with the new package and came across this function: https://github.com/facebook/jest/blob/master/packages/jest-mock/src/index.js#L95 It looks very similar, but different enough that I left it alone for now. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
See: #3527 (comment)
The text was updated successfully, but these errors were encountered: