Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-config shouldn't import getType from matcher-utils #3528

Closed
thymikee opened this issue May 9, 2017 · 9 comments · Fixed by #3559
Closed

jest-config shouldn't import getType from matcher-utils #3528

thymikee opened this issue May 9, 2017 · 9 comments · Fixed by #3559
Assignees

Comments

@thymikee
Copy link
Collaborator

thymikee commented May 9, 2017

See: #3527 (comment)

@thymikee thymikee self-assigned this May 9, 2017
@wyze
Copy link
Contributor

wyze commented May 12, 2017

I could pick this up if you want @thymikee. If it shouldn't use getType should it just use a typeof to get the type? Or just use what is specified by Flow?

@thymikee
Copy link
Collaborator Author

I think you could even copy the whole function for now. We just don't want jest-config to be dependent on rather unrelated jest-matcher-utils library.

@cpojer what do you think about extracting similar shared helper functions into jest-helpers or jest-shared package?

@cpojer
Copy link
Member

cpojer commented May 12, 2017

This one should be jest-get-type or something? ;)

@thymikee
Copy link
Collaborator Author

We're OK with having a package for a single function?

@cpojer
Copy link
Member

cpojer commented May 12, 2017

yes, this is JavaScript.

@thymikee
Copy link
Collaborator Author

sindresorhus style, yea

@wyze
Copy link
Contributor

wyze commented May 12, 2017

Okay, coming right up!

@wyze
Copy link
Contributor

wyze commented May 12, 2017

I was going through and replacing all the instances of getType with the new package and came across this function: https://github.com/facebook/jest/blob/master/packages/jest-mock/src/index.js#L95

It looks very similar, but different enough that I left it alone for now.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants